feat(driver): multishot op#715
Merged
Merged
Conversation
Berrysoft
added
enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements multishot opcode support for io_uring operations, addressing issue #104. Multishot operations allow a single submission to generate multiple completion events, which is useful for operations like reading multiple buffers or receiving multiple network packets without resubmitting the operation each time.
Changes:
- Adds three new multishot operations:
ReadMultiAt,ReadMulti, andRecvMultithat can produce multiple completion results from a single submission - Implements a fallback mechanism via
create_entry_fallback()to gracefully handle unsupported opcodes by falling back to single-shot operations - Introduces
pop_multishot()API to retrieve intermediate results from multishot operations before the final completion
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| compio-driver/tests/file.rs | Adds test cases for multishot read and recv operations, including new test helper push_and_wait_multi |
| compio-driver/src/sys/stub/mod.rs | Provides stub implementation of pop_multishot returning None |
| compio-driver/src/sys/poll/mod.rs | Provides polling driver implementation of pop_multishot returning None (no multishot support) |
| compio-driver/src/sys/iour/op.rs | Implements the three new multishot operation types with fallback to single-shot managed operations, and refactors code with take_buffer helper |
| compio-driver/src/sys/iour/mod.rs | Core multishot support including result queue management, completion handling with more flag detection, and fallback logic |
| compio-driver/src/sys/iocp/mod.rs | Provides IOCP driver stub for pop_multishot returning None |
| compio-driver/src/sys/fusion/op.rs | Adds macro invocations for the three multishot operations in fusion driver |
| compio-driver/src/sys/fusion/mod.rs | Delegates pop_multishot calls to underlying driver and exports take_buffer helper |
| compio-driver/src/op.rs | Exports new multishot operations and implements ResultTakeBuffer for BufResult<usize, Extra> to support buffer extraction |
| compio-driver/src/lib.rs | Adds public pop_multishot method to Proactor API |
| compio-driver/src/key.rs | Adds wake_by_ref method to FrozenKey for waking tasks without consuming the key |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Oh, no. #716 only handles ReadMulti, but cannot handle SendMulti or AcceptMulti, as the opcode are the same for oneshot/multishot ops. There's no way to probe. |
Berrysoft
force-pushed
the
dev/driver-multishot
branch
from
d18f270 to
7dd2a07
Compare
George-Miao
reviewed
Mar 2, 2026
George-Miao
reviewed
Mar 2, 2026
George-Miao
reviewed
Mar 2, 2026
George-Miao
reviewed
Mar 2, 2026
George-Miao
requested changes
Mar 2, 2026
Berrysoft
force-pushed
the
dev/driver-multishot
branch
from
1bdf588 to
5310f37
Compare
George-Miao
reviewed
Mar 3, 2026
George-Miao
requested changes
Mar 3, 2026
Berrysoft
force-pushed
the
dev/driver-multishot
branch
from
9d42c2c to
8d82135
Compare
10 tasks
George-Miao
reviewed
Mar 5, 2026
| need_push_notifier: bool, | ||
| multishot_results: BTreeMap<usize, VecDeque<CEntry>>, | ||
| _local_marker: PhantomData<ErasedKey>, | ||
| multishot_results: HashMap<ErasedKey, VecDeque<CEntry>>, |
Member
There was a problem hiding this comment.
We can implement Ord for ErasedKey if you prefer BTreeMap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #104